This repository was archived by the owner on Oct 5, 2018. It is now read-only.
map_type fixes. mapnik->standard, hide osmarender#11
Open
harry-wood wants to merge 2 commits intodfacts:masterfrom
Open
map_type fixes. mapnik->standard, hide osmarender#11harry-wood wants to merge 2 commits intodfacts:masterfrom
harry-wood wants to merge 2 commits intodfacts:masterfrom
Conversation
added 2 commits
January 15, 2017 01:39
The map_type 'mapnik' value is badly named. Create a new alias 'standard' which is now the new default (which the old 'mapnik' value continues to work as a deprecated value) 'osmarender' has been (badly) mapped to MapQuest open tiles for a while now, so broken because these were discontinued (as was the original 'osmarender' layer) Fix maptype=osmarender so it works, by mapping to osm standard, but obviously this value is also deprecated. Changes to the intro page to reflect this. Fixes https://github.com/dfacts/staticmaplite/issues/3
Define 'mapnik' and 'osmrender' explcitly as aliases of 'standard' rather than just setting to the same tile URL. That approach would mean the aliases will have their own cache directory (which is unnecessary). Now they will all use the 'standard' cache directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map_type 'mapnik' value is badly named. Create a new alias 'standard'
which is now the new default (while the old 'mapnik' value continues to work as
a deprecated value)
'osmarender' has been (badly) mapped to MapQuest open tiles for a while now, so
broken because these were discontinued (as was the original 'osmarender' layer)
Fix maptype=osmarender so it works, by mapping to osm standard, but obviously
this value is also deprecated.
Changes to the intro page to reflect this.
Fixes https://github.com/dfacts/staticmaplite/issues/3
Deployment note: If there's a large cache built up under
../cache/maps/mapnikthat will no longer get used, so you may want to rename that directory as../cache/maps/standard(or maybe you just delete the cache periodically anyway?)